Pass the data with the message in case there is a payload #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the user to decide if they need the payload of the packet itself. This passes the data back to the user so that they can process it if desired.
|
This uses |
|
Fixed @tatsushid — thanks for the feedback |
|
Sorry for the late reply. The code looks good! Thanks for fixing it. This code includes a little API change and it would break the code which uses this library so I will announce about it and merge later. |
|
I wanted to follow up on this and see what your plans were regarding this? |
|
Following up on this, will this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to decide if they need the payload of the packet itself. This passes the data back to the user so that they can process it if desired.