Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve UI of Add Slur form #550

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

Snehil-Shah
Copy link
Contributor

@Snehil-Shah Snehil-Shah commented Apr 24, 2024


name: small patch
about: Improve UI of Add Slur form
labels: enhancement


Relates to #409

Describe the PR

It's a small patch that adds a border to the "What makes it problematic?" text area and restricts reszing to only vertical.

Before: At first glance itself, the cursor feels like in a odd poisiton in the text area with a lot of gap between the border below. Allowing horizontal scroll makes it messier

prev.mp4

After:

tomm.mp4

Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@aatmanvaidya
Copy link
Collaborator

Hi @Snehil-Shah , thank you for enchantment, it looks good, I have tested it out locally, merging the PR

@aatmanvaidya aatmanvaidya merged commit eefd281 into tattle-made:main Apr 25, 2024
3 checks passed
@Snehil-Shah Snehil-Shah deleted the text-area branch April 26, 2024 12:23
@aatmanvaidya
Copy link
Collaborator

hi @Snehil-Shah

one small update to this PR

You had made the enhancement change in the SlurCreate.jsx file, you will also have to make the same change in the SlurEdit.jsx file, as while editing the form too the enhancement should show up.

If you have the time for it, can you create a new PR with the change in the SlurEdit.jsx file

@dennyabrain
Copy link
Contributor

@aatmanvaidya subject to Snehil's availability, if he can't get to it. I suggest we merge this PR if its not breaking the slur edit workflow. A new PR can later on be made to fix this if this is purely a UI improvement.

@aatmanvaidya
Copy link
Collaborator

@dennyabrain yes this PR is already merged, after that it struck me the same change has to be made to the other file.

Its not urgent at all, if Snehil won't be able to get to it, that's fine, I can also make this quick fix.

@Snehil-Shah
Copy link
Contributor Author

@aatmanvaidya Hey, that totally slipped my mind, will make a PR by today itself👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants