Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Delete deprecated DomainsWhiteList struct #205

Closed
samyfodil opened this issue Jul 7, 2024 · 6 comments
Closed

[cleanup] Delete deprecated DomainsWhiteList struct #205

samyfodil opened this issue Jul 7, 2024 · 6 comments
Assignees
Labels
good first issue No deep understanding of tau needed

Comments

@samyfodil
Copy link
Contributor

Delete deprecated struct

type DomainsWhiteList struct {

make sure it's not being used anywhere else.

@samyfodil samyfodil added the good first issue No deep understanding of tau needed label Jul 7, 2024
@vasnt
Copy link
Contributor

vasnt commented Jul 12, 2024

how to find whether it is used elsewhere or not?
e.g.

  • bundleorigin (2 results so it is used elsewhere)

image

  • domainswhitelist (1 result so it confirms not used elsewhere? )
    image

is that correct understanding? or you can advice other ways to find out usage.

@samyfodil
Copy link
Contributor Author

@vasnt that's a good way. looks like it's not used anywhere else. So it just deleting the DomainsWhiteList struct.

vasnt added a commit to vasnt/tau that referenced this issue Jul 12, 2024
@vasnt
Copy link
Contributor

vasnt commented Jul 12, 2024

is there any more action needed after this step?

image

image

@samyfodil
Copy link
Contributor Author

yes, create a pull request

@vasnt
Copy link
Contributor

vasnt commented Jul 12, 2024

created. next?

@samyfodil
Copy link
Contributor Author

I'll run test and review. if all good, I'll merged it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue No deep understanding of tau needed
Projects
None yet
Development

No branches or pull requests

2 participants