[window-state][v2] macOS using plugins causes apps to get stuck

[ayangweb]

demo: https://github.com/ayangweb/test-window-state

macOS video:

The mouse is always loading, but the screen recorder doesn't record it.

10.11.2.mov

Windows video:

10.11.3.mov

More demo videos

[hut36]

Ran into the same problem. Tried to fix it and this is my investigation so far:

• The problem is triggered by the call to is_maximized() from within restore_state()
• The problem is caused by the call to is_maximized() from WindowEvent::Resized event handler. The tao implementation of is_zoomed() (the counterpart of is_maximized()) for MacOS sets NSWindowStyleMask::NSTitledWindowMask | NSWindowStyleMask::NSResizableWindowMask in case of no title and not resizable, which most probably causes event resized be emitted.
• this can be verified by setting windows > decorations or windows > resizable to false in tauri.conf.json, and delete .window-state.json before running the app.

[ayangweb]

I've implemented a simple version on my own for now that runs relatively stable, looking forward to fixing it soon 🌹!

EcoPasteHub/EcoPaste#677

[hut36]

Just comment out this line if you want a quick workaround.

plugins-workspace/plugins/window-state/src/lib.rs

Line 475 in 7e1c17a

&& !window_clone.is_maximized().unwrap_or_default()

[hut36]

Same reason: tauri-apps/tauri#5812

[1111mp]

Same problem on macos

[ayangweb]

@FabianLars @amrbashir Hey 👋, bothering you both, any progress on this issue?

[FabianLars]

I looked into it only very very briefly. Maybe it makes sense to disable the is_maximzed check in the plugin for undecorated windows for now. Actually fixing the inner issue may take a while.