fix(deep-link): emit new-url event on app load #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through dfa7478There are 3 changes which include deep-link with prerelease, fs with prerelease, single-instance with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
reviewed
Sep 12, 2024
Comment on lines
+212
to
+214
| } else if cfg!(debug_assertions) { | ||
| log::warn!("argument {url} does not match any configured deep link scheme; skipping it"); | ||
| } |
There was a problem hiding this comment.
do we really need to warn! here, shouldn't we just skip it?
There was a problem hiding this comment.
i think it's still important in case the dev is using runtime schemes and isn't aware of why it isn't being picked up for missing a note in the docs
amrbashir
approved these changes
Sep 12, 2024
Sir-Thom
pushed a commit
to Sir-Thom/plugins-workspace
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matching the behavior on all desktop platforms