Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update rust crate rfd to 0.15 (v2) #1805

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 18, 2024

This PR contains the following updates:

Package Type Update Change
rfd dependencies minor 0.14 -> 0.15

Release Notes

PolyMeilex/rfd (rfd)

v0.15.0

Compare Source

  • Move from objc crates to objc2 crates.
  • Fix AsyncFileDialog blocking the executor on Windows (#​191)
  • Add TDF_SIZE_TO_CONTENT to TaskDialogIndirect config so that it can display longer text without truncating/wrapping (80 characters instead of 55) (#​202)
  • Fix xdg-portal backend not accepting special characters in message dialogs
  • Make set_parent require HasWindowHandle + HasDisplayHandle
  • Add support for set_parent in XDG Portals
  • Update ashpd to 0.9.
  • Add support for files without an extension in XDG Portal filters
  • Derive Clone for FileHandle

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Sep 18, 2024
@renovate renovate bot requested a review from a team as a code owner September 18, 2024 22:07
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Package Changes Through d8b4c00

There are 2 changes which include deep-link with prerelease, dialog with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.0-rc.7 2.0.0-rc.8
deep-link 2.0.0-rc.6 2.0.0-rc.7
dialog 2.0.0-rc.7 2.0.0-rc.8
single-instance 2.0.0-rc.4 2.0.0-rc.5

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Contributor Author

renovate bot commented Sep 19, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@FabianLars
Copy link
Member

i wonder if we're at a point now where it makes more sense to just store rfd's builder inside our builder (on desktop only ofc) so we don't need this custom stuff...

@Legend-Master
Copy link
Contributor

Sounds good to me, looking at the current code, it's pretty much two different paths anyways, and we don't store the builders, so not much need for it

@Legend-Master
Copy link
Contributor

Maybe do it in another PR? Maybe could also address this

I just noticed that we're using Ok and Cancel as default in the confirm and ask here, is there any reason not to use the system default here?
https://discord.com/channels/616186924390023171/986184094050316358/1285617586045980724

@FabianLars
Copy link
Member

fine with me

Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just get this one in then

@Legend-Master Legend-Master merged commit 6bf1bd8 into v2 Sep 19, 2024
16 checks passed
@Legend-Master Legend-Master deleted the renovate/v2-rfd-0.x branch September 19, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants