refactor(dialog)!: use enum instead of label for buttons #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 45e5088There are 4 changes which include deep-link with prerelease, dialog with prerelease, fs with prerelease, updater with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
lucasfernog
approved these changes
Oct 1, 2024
lucasfernog
added a commit
to tauri-apps/tauri-docs
that referenced
this pull request
Oct 1, 2024
I'm not totally happy with how the dialog docs layout is completely different from the others, but I'm not willing to change it right now - especially not without discussing with the other docs maintainers this PR clarifies the return path format for Android and iOS, and also updates the Rust examples following the change from tauri-apps/plugins-workspace#1842
gezihuzi
pushed a commit
to Hypobenthos/plugins-workspace
that referenced
this pull request
Oct 3, 2024
…1842) * refactor(dialog)!: use enum instead of label * Add change file * Fix doc comment typo * Move ok and cancel to lib.rs
Sir-Thom
pushed a commit
to Sir-Thom/plugins-workspace
that referenced
this pull request
Oct 22, 2024
…1842) * refactor(dialog)!: use enum instead of label * Add change file * Fix doc comment typo * Move ok and cancel to lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to use the default OS dialog buttons texts instead of always defaulting to
OkandCancel