Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deep-link): Remove getCurrent call in onOpenUrl #2008

Merged
merged 3 commits into from
Nov 9, 2024

Conversation

FabianLars
Copy link
Member

I received multiple reports that this behavior causes issues, like when reloading pages or re-mounting components. It's also not the behavior people seem to expect. Also, the function docs actually told users to use getCurrent themselves.

I'm not 100% sure about the rust side. The issues you see on the rust side aren't as apparent and the docs are also correct there but i think it would make sense to also change it.

@FabianLars FabianLars requested a review from a team as a code owner November 5, 2024 17:53
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Package Changes Through c5ca148

There are 2 changes which include deep-link with patch, deep-link-js with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
deep-link-example-js 2.0.0 2.0.1
deep-link 2.0.1 2.0.2
deep-link-js 2.0.0 2.0.1
single-instance 2.0.1 2.0.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member Author

i did the same for the rust side, can revert if desired

Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as the examples show that you must check current before listening for events that's ok

@lucasfernog lucasfernog merged commit b2aea04 into v2 Nov 9, 2024
18 checks passed
@lucasfernog lucasfernog deleted the fix/deep-link-idk branch November 9, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deep-link][v2] onOpenUrl Listener is being triggered when mounting even if the even was already processed
2 participants