fix(deep-link): Remove getCurrent call in onOpenUrl #2008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I received multiple reports that this behavior causes issues, like when reloading pages or re-mounting components. It's also not the behavior people seem to expect. Also, the function docs actually told users to use getCurrent themselves.
I'm not 100% sure about the rust side. The issues you see on the rust side aren't as apparent and the docs are also correct there but i think it would make sense to also change it.