fix(log): inconsistent webview log target #2021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make webview log target more consistent that it always starts with
"webview"
The
WEBVIEW_TARGET
target (the value used to be"Webview"
) is never actually being used before, and the location info was only generated for the webkit based before (also they seem to be the current location instead of the caller's location)So this PR changes the behavior to use the caller's location, format it like
webview:bar@filename.js:6:3
, fallback towebview
Fix #1058