Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): inconsistent webview log target #2021

Merged

Conversation

Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Nov 8, 2024

Make webview log target more consistent that it always starts with "webview"

The WEBVIEW_TARGET target (the value used to be "Webview") is never actually being used before, and the location info was only generated for the webkit based before (also they seem to be the current location instead of the caller's location)

So this PR changes the behavior to use the caller's location, format it like webview:bar@filename.js:6:3, fallback to webview

Fix #1058

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Package Changes Through e2b1f19

There are 3 changes which include log-plugin with patch, log-js with patch, localhost with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.5 2.0.6
api-example-js 2.0.2 2.0.3
localhost 2.0.1 2.1.0
log-plugin 2.0.2 2.0.3
log-js 2.0.0 2.0.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master Legend-Master marked this pull request as ready for review November 9, 2024 03:10
@Legend-Master Legend-Master requested a review from a team as a code owner November 9, 2024 03:10
@Legend-Master
Copy link
Contributor Author

Note: I didn't test the JavaScriptCore stack trace parser, just used the old one with the third line instead the of the first line

Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(didn't test this sry - looks nice though)

@Legend-Master Legend-Master merged commit 371a2f7 into tauri-apps:v2 Nov 12, 2024
18 checks passed
@Legend-Master Legend-Master deleted the fix-inconsistent-webview-log-target branch November 12, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[log] target filter doc string example doesn't actually work
2 participants