fix(persisted-scope): Prevent memory leaks, fixes #274 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ern is allowed already.
|
We may have to look into deleting files that are too large before reading them in the future because some users reported OOM crashes. In the PR tests Windows didn't report any memory usage raise when reading a 50MB, but no idea if Rust just handles this extremely well or if Windows just doesn't want to report it in time (even though it has like 5 secs lol) Edit: Tested it with the current dev branch and Windows does report the insane memory usage correctly so maybe Rust is indeed doing a great job here 👀 |
OrIOg
pushed a commit
to OrIOg/plugins-workspace
that referenced
this pull request
Jun 25, 2023
(tauri-apps#328) * fix(persisted-scope): Unescape paths before saving to disk. * fix cfg flags * dedupe code * unescape when reading to try to fix existing files * add more patterns. only fix pattern on app start. don't check if pattern is allowed already. * remove dbg log * typo * remove unused imports * clippy * fix compilation with asset-protocol feature flag enabled * update patterns * manually re-save state once * add changefile * remove dbg print
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not actually a memory leak the plugin just breaks the .persisted-scope file, bloating it up (to 100mb after a few uses/restarts if you actually use the scope) to a point where it gets too large to work correctly.
This PR adds more pattern than strictly necessary to fix existing files seamlessly - well, hopefully at least.
Fixes #274