Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fs): use scope from tauri core #825

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Conversation

lucasfernog
Copy link
Member

On Android, when we call canonicalize() on "/data/user/0/appid" (which is the data dir), the result is a "/data/data/appid" path, so we need to adjust our scope for that.

Tauri fix: tauri-apps/tauri#8420

On Android, when we call canonicalize() on "/data/user/0/appid" (which is the data dir), the result is a "/data/data/appid" path, so we need to adjust our scope for that.
@lucasfernog lucasfernog requested a review from a team as a code owner December 16, 2023 19:44
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never noticed before but seems like we have a duplicate code of the fs scope module that already exists in Tauri, so I'd suggest turning this PR into a removal of this scope here and reuse the one from tauri.

@lucasfernog
Copy link
Member Author

Needs tauri-apps/tauri#8432

@lucasfernog lucasfernog changed the title fix(fs): scope checks on Android refactor(fs): use scope from tauri core Dec 19, 2023
@lucasfernog lucasfernog merged commit 10b8039 into v2 Dec 20, 2023
31 of 32 checks passed
@lucasfernog lucasfernog deleted the fix/android-scope-check branch December 20, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants