fix(events): properly fire WindowEvent::Destroyed on Linux (#349)

* fix(events): properly fire `WindowEvent::Destroyed` on Linux

* remove unused variable

* fix docs

.changes/fix-gtk-destroyed-event.md

@@ -0,0 +1,5 @@
+---
+"tao": patch
+---
+
+Properly fire `WindowEvent::Destroyed` on Linux when the `Window` is dropped.

examples/window.rs

@@ -9,14 +9,15 @@ use tao::{
 
 #[allow(clippy::single_match)]
 fn main() {
-  env_logger::init();
   let event_loop = EventLoop::new();
 
-  let window = WindowBuilder::new()
-    .with_title("A fantastic window!")
-    .with_inner_size(tao::dpi::LogicalSize::new(128.0, 128.0))
-    .build(&event_loop)
-    .unwrap();
+  let mut window = Some(
+    WindowBuilder::new()
+      .with_title("A fantastic window!")
+      .with_inner_size(tao::dpi::LogicalSize::new(128.0, 128.0))
+      .build(&event_loop)
+      .unwrap(),
+  );
 
   event_loop.run(move |event, _, control_flow| {
     *control_flow = ControlFlow::Wait;
@@ -25,11 +26,23 @@ fn main() {
     match event {
       Event::WindowEvent {
         event: WindowEvent::CloseRequested,
-        window_id,
+        window_id: _,
         ..
-      } if window_id == window.id() => *control_flow = ControlFlow::Exit,
+      } => {
+        // drop the window to fire the `Destroyed` event
+        window = None;
+      }
+      Event::WindowEvent {
+        event: WindowEvent::Destroyed,
+        window_id: _,
+        ..
+      } => {
+        *control_flow = ControlFlow::Exit;
+      }
       Event::MainEventsCleared => {
-        window.request_redraw();
+        if let Some(w) = &window {
+          w.request_redraw();
+        }
       }
       _ => (),
     }

src/event.rs

@@ -326,6 +326,11 @@ pub enum WindowEvent<'a> {
   CloseRequested,
 
   /// The window has been destroyed.
+  ///
+  /// ## Platform-specific
+  ///
+  /// - **Windows / Linux:** Only fired if the [`crate::window::Window`] is dropped.
+  /// - **macOS:** Fired if the [`crate::window::Window`] is dropped or the dock `Quit` item is clicked.
   Destroyed,
 
   /// A file has been dropped into the window.

src/platform_impl/linux/event_loop.rs

@@ -451,7 +451,7 @@ impl<T: 'static> EventLoop<T> {
             });
 
             let tx_clone = event_tx.clone();
-            window.connect_destroy_event(move |_, _| {
+            window.connect_destroy(move |_| {
               if let Err(e) = tx_clone.send(Event::WindowEvent {
                 window_id: RootWindowId(id),
                 event: WindowEvent::Destroyed,
@@ -461,7 +461,6 @@ impl<T: 'static> EventLoop<T> {
                   e
                 );
               }
-              Inhibit(false)
             });
 
             let tx_clone = event_tx.clone();