Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quit and Hide native menu items should include app name #536

Closed
caesar opened this issue Aug 17, 2022 · 0 comments · Fixed by #570 or #562 · May be fixed by grant0417/tao#1
Closed

Quit and Hide native menu items should include app name #536

caesar opened this issue Aug 17, 2022 · 0 comments · Fixed by #570 or #562 · May be fixed by grant0417/tao#1
Labels
priority: low Nice to have type: feature request

Comments

@caesar
Copy link
Contributor

caesar commented Aug 17, 2022

Just like the About menu item, the Quit and Hide items should also include the app name on macOS to follow platform conventions.

Here's an example of the correct behaviour:
Screenshot 2022-08-17 at 22 14 38

And here's a Tauri app:
Screenshot 2022-08-17 at 22 23 03
@caesar caesar mentioned this issue Sep 25, 2022
Merged
13 tasks
amrbashir pushed a commit that referenced this issue Sep 25, 2022
@caesar
fix(menus): add app name to native Quit and Hide items on macOS, closes
65f768e 
#536 (#570)

* feat(menus): add app name to native Quit and Hide items

* lint: run cargo fmt

* refactor(menus): cleaner app name implementation

* chore(menus): add changefile

* chore(menus): change changefile

* refactor(menus): keep original app_name function signature

* refactor(menus): add helper function `app_name_string`
@github-actions github-actions bot mentioned this issue Sep 25, 2022
Merged
@caesar caesar mentioned this issue Sep 25, 2022
Closed
This was referenced Oct 5, 2022
Closed
Open
@github-actions github-actions bot mentioned this issue Nov 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low Nice to have type: feature request
Projects
None yet
Milestone
No milestone
2 participants
@caesar @amrbashir