-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement global shortcut on Linux, close #307 #308
Conversation
This one set accelerator group to each window. It's not the real global shortcut. If no window is active, all shortcuts won't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been thinking we should remove globalShortcut module anyway and use DeviceEvent::Key
and tauri or any tao user can keep their own hashmap of global shortcuts and build their global shortcut manager as they see fit on top of DeviceEvent::Key
, this has been also proposed by a maintainer at winit. This could also help us when we move back to winit.
DeviceEvent::Key
is currently not implemented on gtk I think.
cc @lucasfernog
I think that can be part of a next iteration, maybe for Tauri 1.1 since it's too big of a change to do it now. |
Sounds good to me. Now we only need to make this PR global and not specific to a window. |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information