Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trivial tray features #411

Merged
merged 2 commits into from
May 30, 2022
Merged

Remove trivial tray features #411

merged 2 commits into from
May 30, 2022

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented May 30, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@wusyong wusyong requested a review from a team May 30, 2022 06:03
@wusyong wusyong requested a review from a team as a code owner May 30, 2022 06:03
@wusyong
Copy link
Member Author

wusyong commented May 30, 2022

@FabianLars @lucasfernog Do you agree on this? If so, I want to publish this as soon as possible.

@FabianLars
Copy link
Member

Fine by me 👍

What do you think about removing the tray feature from the default features?

@wusyong
Copy link
Member Author

wusyong commented May 30, 2022

Sure, I think it's also more reasonable.

@lucasfernog
Copy link
Member

Seems good, we can deal with it at Tauri.

@wusyong wusyong merged commit f1bd25e into dev May 30, 2022
@wusyong wusyong deleted the tray branch May 30, 2022 15:52
@github-actions github-actions bot mentioned this pull request May 30, 2022
@nazar-pc
Copy link
Contributor

I traced ayatana removal to here, why did it happen?
I can't build it on Ubuntu 22.04 anymore because I have libayatana-appindicator instead of libappindicator installed.

Before this PR ayatana-tray was the default feature, now it is not possible to use at all, I'm confused why this PR is a "feature" and not a major breaking change.

@nazar-pc nazar-pc mentioned this pull request Jul 22, 2022
13 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants