Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add WindowBuilder::with_focused #576

Merged
merged 11 commits into from
Oct 3, 2022
Merged

feat: add WindowBuilder::with_focused #576

merged 11 commits into from
Oct 3, 2022

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Sep 30, 2022 •
edited
Loading

ref: tauri-apps/tauri#5120

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner September 30, 2022 17:57
keiya01
keiya01 approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@keiya01 keiya01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on macos

@lucasfernog
Copy link
Member

@amrbashir this doesn't really work on Linux :( accepts_focus forces the window to never receive focus :(

@amrbashir
Copy link
Member Author

pushed a little workaround, hope that fixes it.

@amrbashir amrbashir closed this Oct 3, 2022
@amrbashir amrbashir deleted the window-builder-focus branch October 3, 2022 18:43
@amrbashir
Copy link
Member Author

Doesn't work on Linux at all

@amrbashir amrbashir restored the window-builder-focus branch October 3, 2022 19:03
@amrbashir amrbashir reopened this Oct 3, 2022
amrbashir
amrbashir commented Oct 3, 2022
View reviewed changes
src/window.rs Show resolved Hide resolved
src/window.rs Show resolved Hide resolved
src/platform_impl/linux/window.rs Show resolved Hide resolved
@amrbashir amrbashir merged commit e42ff07 into dev Oct 3, 2022
@amrbashir amrbashir deleted the window-builder-focus branch October 3, 2022 20:57
This was referenced Oct 3, 2022
Merged
Closed
@github-actions github-actions bot mentioned this pull request Oct 11, 2022
Open
@github-actions github-actions bot mentioned this pull request Nov 1, 2022
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

@keiya01 keiya01 keiya01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrbashir @lucasfernog @keiya01