Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cursor_position #668

Merged
merged 6 commits into from
Jan 12, 2023
Merged

feat: add cursor_position #668

merged 6 commits into from
Jan 12, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jan 10, 2023 •
edited by wusyong
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

Other information

TODOs:

  • test and confirm macOS

@amrbashir amrbashir requested a review from a team as a code owner January 10, 2023 00:24
@wusyong wusyong self-requested a review January 11, 2023 13:40
@wusyong
Copy link
Member

wusyong commented Jan 12, 2023

macOS is working btw.

@amrbashir amrbashir merged commit 5d8bf51 into dev Jan 12, 2023
@amrbashir amrbashir deleted the feat/cursor-position branch January 12, 2023 13:09
@github-actions github-actions bot mentioned this pull request Jan 12, 2023
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add monitor::cursor_position()
2 participants
@amrbashir @wusyong