Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos/menu): set native image height to 18 #746

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 5, 2023

closes tauri-apps/tauri#7077

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

Other information

@amrbashir amrbashir requested a review from a team as a code owner June 5, 2023 11:08
@wusyong wusyong merged commit 5af3da4 into dev Jun 5, 2023
@wusyong wusyong deleted the fix/macos/native-image-height branch June 5, 2023 11:29
@github-actions github-actions bot mentioned this pull request Jun 5, 2023
amrbashir added a commit that referenced this pull request Jun 5, 2023
* fix(macos/menu): set native image height to 18

closes tauri-apps/tauri#7077

* Update menu.rs
@amrbashir
Copy link
Member Author

amrbashir commented Jun 5, 2023

cherry picked into v0.16 branch 0371359

@github-actions github-actions bot mentioned this pull request Jun 5, 2023
This was referenced Jul 3, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Some NativeImage on CustomMenuItem are too big for menu and tray
2 participants