On Windows, set name of Window Class #769 for v0.16 #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow to customize it instead of current value hard coded "Window Class"
amrbashir
requested changes
Jul 26, 2023
| @@ -1131,8 +1131,8 @@ unsafe fn init<T: 'static>( | |||
| Ok(win) | |||
| } | |||
|
|
|||
| unsafe fn register_window_class() -> Vec<u16> { | |||
| let class_name = util::encode_wide("Window Class"); | |||
| unsafe fn register_window_class<T: 'static>(window_classname: &String) -> Vec<u16> { | |||
There was a problem hiding this comment.
Suggested change
| unsafe fn register_window_class<T: 'static>(window_classname: &String) -> Vec<u16> { | |
| unsafe fn register_window_class(window_classname: &str) -> Vec<u16> { |
| @@ -945,7 +945,7 @@ unsafe fn init<T: 'static>( | |||
| event_loop: &EventLoopWindowTarget<T>, | |||
| ) -> Result<Window, RootOsError> { | |||
| // registering the window class | |||
| let class_name = register_window_class(); | |||
| let class_name = register_window_class::<T>(&pl_attribs.window_classname); | |||
There was a problem hiding this comment.
Suggested change
| let class_name = register_window_class::<T>(&pl_attribs.window_classname); | |
| let class_name = register_window_class(&pl_attribs.window_classname); |
|
Just noticed this PR was opened against v0.16 branch, lets just focus on #770 and then I will cherry-pick it into v0.16 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow to customize it instead of current value hard coded "Window Class"
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
Other information