-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n (JP) - Draft of Japanese text for "Quick Start" Section #3111
base: v2
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for tauri-v2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
FYI you need to register the locale at https://github.com/tauri-apps/tauri-docs/blob/v2/locales.json and https://github.com/tauri-apps/tauri-docs/blob/v2/lunaria.config.json and it's possible to translate labels here https://github.com/tauri-apps/tauri-docs/blob/v2/astro.config.mjs and you can track translations here https://v2.tauri.app/contribute/translate-status/ and I'm 99% sure there's no need to add rev on the files, as the tracker already does this, unless there's something else I'm missing if you still need help with the technical stuff you can tag me and if by any chance you know someone who could help to review your translation, they're welcome. |
@vasfvitor Lastly, I reviewed Netlify error reports but I could not find the error locations (Tauri Doc site is highly automated and beyond my comprehension - the more I change the files, the more errors are coming...). If you have time, would you kindly help to correct the affected files so that they are merged into the main branch? Thank you for your kind assistance in advance. |
hi @penginnu, @Kenzo-Wada, @takavfx we just enabled Japanese locale, does any of you still interested in helping out?. We could use some help on reviewing this PR (just the basics to ensure it's ok and nothing is off, no need to be picky) and continue with the translation effort on other pages. |
notes:
heading: Migrate to New Window Api translated: 新しい Window API への移行 if unsure about the anchor you can always go to the page, find the heading and click at it, then the anchor will be appended to the site url live preview is posted above by the bot, but here it is anyway https://deploy-preview-3111--tauri-v2.netlify.app/jp/ |
@vasfvitor BTW, I saw the preview of the JP pages which are very nicely created. Thank you again for your kind helps. I also noted that "Japanese" is already added to Tauri's top page language selector. |
@vasfvitor
|
Usually a maintainer have to manually run workflows, I'll now.
simply speaking "close" is "delete" and "merge" is "integrate". It's possible to reopen once close. And only the team can merge. The PR status is not 'approved', technically speaking. Is it ready for review? It would be good if you can bring someone native to review this. Ah, I'm not sure if you noticed, but there's an option to mark this PR as a draft and then when everything is ready you can mark as "ready to review" |
@J1-takai I ran the "format" command and this is the changes it has done bb2d450 It shouldn't change the meaning of anything. and I did a quick research and found out that it should be "ja" and not "jp" for the locale. I'll make the changes |
i18n (JP) Translation for "Quick Start" section
This is a trial translation work for "Tauri Doc 2.0 Japanese Version" from the scratch. If there are any similar activities already on-going, please disregard this pull request. If not, my drafts would need technical proof-reading as I have almost no knowledge on programming - my only programming experiences were introductory courses for FORTRAN and COBOL using punch cards data loading some 40 years ago, HA HA! No rush - Please take your time.