-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Option for native titlebar buttons #4973
Comments
This is covered by #2663, even though the discussion was primarily about macos, but that's only because it's much more of a problem there. Though i think we'll introduce Windows support slightly different, at least in the first iteration. So instead of a whole titlebar we'll just offer a way to make an element by choice react to this https://docs.microsoft.com/en-us/windows/apps/desktop/modernize/apply-snap-layout-menu#how-do-i-fix-it, but we'll see 🤷 Thanks for the FR! |
Even better |
@FabianLars ideally Windows would get better support than that, as building your own accurate titlebar is difficult. Themeable and/or button overlay would be ideal. |
@MulverineX It's not like we don't want to, the problem is that Windows doesn't have similar APIs (to our knowledge at least - i'd love to be proven wrong here). |
@FabianLars electron/electron#33066 . I had commented this on #2663 |
@MulverineX Yep i saw that, but if we take a look at the PR where WOC itself was implemented: https://github.com/electron/electron/pull/29600/files it shows that it's insanely complicated as it's draws the controls completely manually. The main problem with that is that we don't draw anything manually in our libraries so we don't have anything we could build upon, therefore i think this way is not feasible for us. p.s. i know that chromium itself implemented WCO recently (v102 or something?), but i don't see any way to activate or control it in WebView2 :/ |
@FabianLars damn, I thought the Electron team had found a proper system API for it :/. Guess that doesn't really exist, that's disappointing. Well, hopefully, it roles out to webview2 eventually. Thanks for elaborating. |
Describe the problem
It would be really nice to have an option like
titlebarOverlay
option in electron.While we can create a custom titlebar, since win 11, there is an option for a quick snap layout as described here.
This way we can still make a custom titlebar while keeping the native buttons.
Describe the solution you'd like
Either via plugin, or
window
configuration.Alternatives considered
None
Additional context
None
The text was updated successfully, but these errors were encountered: