-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Error handling crate to thiserror #613
Comments
@tensor-programming was discussing moving to |
Looks like |
One thing tho - I was running some |
Do you mean something like abort on panic? (which will not unwind the error stack) |
well - its a tradeoff - i don't want to crash if it can be avoided, but i also don't want to give reversers / hackers information that will inform them about what is going on under the hood |
Yeah, in that case we could add this to abort on panic in release build.
Btw, this probably should be a topic on its own. Maybe split this into another issue later. |
agreed - its something definitely for the docs - will create that over there |
Do you want to start working on the PR @wusyong ? |
Sure, I would like to take it. |
I've started work on my own PR not seeing yours or this issue (sorry about that). If you want; we can merge the two; I don't want to minimize the work you've already done. I've started with the bundler and in doing so also cleaned up some of the old error codes. Ill have you help me on the actual lib crates; if you don't mind. (we can adapt the work you've already done.) |
Thanks, I think I can leave bundler untouched. |
Thank you, sorry again. You did some great work on #621. |
Is your feature request related to a problem? Please describe.
I would like to open a PR, but looks like it's better to file an issue first. As
failure
is already deprecated, it seemserror-chain
will be the same even it hasn't updated the badge to toml file yet. So I think it's better update to a more modern error handling type crate likethiserror
as soon as we have time. Especially thiserror is already v1.0 and its interface should be lighter and intuitive.Describe the solution you'd like
Replace error-chain with thiserror v1.0.
Describe alternatives you've considered
As a crate being binary/executable, maybe it doesn't need to have a well-typed error as long as there's way to retrieve actual error. In this case, we can even use
anyhow
which can make error handling even more easier.Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: