Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] NSIS installer does not clean up /redist/MicrosoftEdgeWebview2setup.exe after install and uninstall. #7409

Closed
jetli opened this issue Jul 12, 2023 · 2 comments
Closed

[bug] NSIS installer does not clean up /redist/MicrosoftEdgeWebview2setup.exe after install and uninstall. #7409

jetli opened this issue Jul 12, 2023 · 2 comments
Labels
platform: Windows scope: bundler The bundler used in our cli to make installers status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@jetli
Copy link
Contributor

jetli commented Jul 12, 2023

Describe the bug

webviewInstallMode is silent=true and type=embedBootstrapper. If user does not have webview2 runtime, NSIS installer will add a dir and file: /redist/MicrosoftEdgeWebview2setup.exe to installation directory, but after installation, this dir is not cleaned up. and when user uninstall the app, this dir is not cleaned up again, leaving /redist/MicrosoftEdgeWebview2setup.exe there.

Reproduction

No response

Expected behavior

NSIS installer should clean up /redist/MicrosoftEdgeWebview2setup.exe after installation.

Platform and versions

[✔] Environment
    - OS: Windows 10.0.19045 X64
    ✔ WebView2: 114.0.1823.67
    ✔ MSVC:
        - Visual Studio Community 2019
        - Visual Studio 生成工具 2022
    ✔ rustc: 1.70.0 (90c541806 2023-05-31)
    ✔ Cargo: 1.70.0 (ec8a8a0ca 2023-04-25)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (environment override by RUSTUP_TOOLCHAIN)
    - node: 16.18.0
    - yarn: 3.2.4
    - npm: 8.19.2

[-] Packages
    - tauri [RUST]: 1.4.1
    - tauri-build [RUST]: 1.4.0
    - wry [RUST]: 0.24.3
    - tao [RUST]: 0.16.2
    - @tauri-apps/api [NPM]: not installed!
    - @tauri-apps/cli [NPM]: 1.4.0

[-] App
    - build-type: bundle
    - CSP: unset
    - distDir: ../dist
    - devPath: http://localhost:1420/

Stack trace

No response

Additional context

No response
@jetli jetli added status: needs triage This issue needs to triage, applied to new issues type: bug labels Jul 12, 2023
@FabianLars FabianLars added platform: Windows scope: bundler The bundler used in our cli to make installers labels Jul 12, 2023
@FabianLars
Copy link
Member

Thanks for the report.

When we fix this we may want to consider writing that file to a well-known temp dir instead of the installdir if possible too imo.

@jetli
Copy link
Contributor Author

jetli commented Jul 12, 2023

yes, a temp dir is a great idea.

amrbashir added a commit that referenced this issue Jul 25, 2023
@jetli @amrbashir
fix(bundler/nsis): use temp dir for webview2 installer, closes #7409 (#…
57f73f1 
…7486)

* fix(bundler/nsis): use temp dir for webview2 installer, closes #7409

* Update .changes/fix-nsis-webview2-installer-use-tempdir.md

---------

Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform: Windows scope: bundler The bundler used in our cli to make installers status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jetli @FabianLars @amrbashir