Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core)!: rename plugin::PermissionState::Unknown to plugin::PermissionState::Prompt #10978

Merged
merged 4 commits into from
Sep 13, 2024
Merged

refactor(core)!: rename plugin::PermissionState::Unknown to plugin::PermissionState::Prompt #10978

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86d9abd
fix(core): plugin::PermissionState::Unknown wrong display impl
lucasfernog Sep 12, 2024
58ab808
prompt
lucasfernog Sep 12, 2024
45755c9
rename variant
lucasfernog Sep 13, 2024
68d12f8
fix
lucasfernog Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/fix-permission-state-unknown-display.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"tauri": patch:bug
---

Fix display implementation of `PermissionState::Unknown` not generating the `prompt` string.
2 changes: 1 addition & 1 deletion crates/tauri/src/plugin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,7 @@ impl std::fmt::Display for PermissionState {
Self::Granted => write!(f, "granted"),
Self::Denied => write!(f, "denied"),
Self::PromptWithRationale => write!(f, "prompt-with-rationale"),
Self::Unknown => write!(f, "Unknown"),
Self::Unknown => write!(f, "prompt"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the variant be named Prompt then?

}
}
}
Expand Down