-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(macos): title_bar_style
and hidden_title
window options, closes #2663
#3965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this needs to wait for v2
These APIs existed when tao was being audited so if it is really a high demand feature, we can maybe include it?
It is the most upvoted issue, so it sure does have demand |
c38e2a5
to
a67005d
Compare
Yes, it is really a high demand feature. |
I use this in my Tauri fork. I love it. Some thoughts on the feature itself:
Some technical thoughts:
|
I'm not sure if going the
None of the above "hide" the titlebar, because the title and traffic lights can still be visible. In fact, in tao (and Xcode storyboards), hiding the titlebar
|
transparent_titlebar
window option, closes #2663title_bar_style
and hidden_title
window options, closes #2663
Went with this: enum TitleBarStyle {
Visible,
Transparent,
Hidden,
} |
You mean all elements within the titlebar?
I like this 👍 |
No, everywhere in the window. I've seen it on some apps in the wild and it's great. Works for people that assume you have to drag from top too, so no learning curve, and no other downsides afaik. |
@JonasKruckenberg Sorry, this is actually what I went with: enum TitleBarStyle {
Visible,
Transparent,
Overlay,
} The reasoning is what I explained above |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Looks good to me, but I'm not seeing any differences with the Transparent mode (though Overlay looks amazing!) @probablykasper |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
I assume this needs to wait for v2