Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): manual config lookup to handle gitignored folders, fixes #3527 #4224

Merged
merged 1 commit into from
May 26, 2022

Conversation

FabianLars
Copy link
Member

@FabianLars FabianLars commented May 26, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Turns out more people than expected have (parts of) their project gitignored and we currently only check if $CWD/tauri.conf.json exists which doesn't work for the most common structure == the one you get via CTA/tauri init.

The proposed workaround is really straightforward, we just manually check for src-tauri/tauri.conf.json before starting the actual lookup.
A nice-to-have side-effect is that this slightly improves performance for projects with the default structure 🤷

@FabianLars FabianLars requested a review from a team May 26, 2022 17:50
@FabianLars FabianLars requested a review from a team as a code owner May 26, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants