-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Linux): Fix libwebkit2gtk-4.0 not available issue #9863
base: 1.x
Are you sure you want to change the base?
fix(Linux): Fix libwebkit2gtk-4.0 not available issue #9863
Conversation
This size increase is not desired and is a breaking change, instead it should be an opt-in. We should also document how users can add a PPA to their system so they can install required packages. |
Agreed because this change would break support for building .deb bundles on non debian/ubuntu distros. Also, make sure to test the installation on systems that don't have webkitgtk installed (via the 2204 repo workaround). I mean, running the app after the app, not just the installation. |
Well,
Well, I thought about this, and tried this as well. But the issue is : It can break dependency tree, and may even lead to breaking entire desktop environment for some users. So, it is quite risky.
No, it won't. I tested it on Arch Linux, Manjaro, Ubuntu 22. I am gonna test it on Fedora as well.
It is not possible to run Tauri itself without |
That still doesn't justify making this breaking changes. Also
Then we just make a PPA that we maintain ourselves that contains only |
All we need is that
Yeah, I understand the concerns. That's why it took me so much time in search of other alternatives.
We have a couple of more libraries, and not only I have another cool idea, can we just create another
|
It is not only for development, end-users need to be able to install it as well.
I know, thanks for your help but I honestly can't approve this solution unless it is an opt-in.
How many more dependencies? and excuse my ignorance but what does maintaining a PPA entails? what would I need to do on a daily basis to maintain it?
That could work but I am not keen on it either, it means each application will distribute a different version of libwebkit2gtk and could potentially endup with an outdated version or conflict with other versions installed from another apps. |
Yeah, this PR basically copies the
We would need a server, that can fetch and build the package. I am really not sure, if Github actions can be used, because I have never seen anyone using it. Not much stuff. But it is more troublesome on the users' end, since they have to add PPA manually. We can create a script for that as well ( it can be done pretty easily with
Well, we can ship it via Tauri Website maybe.
Outdated version is required in this case 😅
No, it won't conflict with other apps, as we are shipping it as a 3rd party app. |
Can't we just fetch from the old ubuntu PPA? or even just add a pre-built packages?
Why not?
I meant outdated version of this new
I meant conflict with other tauri apps, not other non-tauri apps. |
Yeah, we can do that.
Yeah, it won't conflict with any Tauri App as well, since user have to install it just once, and forget about it. |
I guess that could work, but I'd still like to see that as opt-in, so tauri users can know what is required on their part. |
I think we should try solving this by addressing all of these points:
|
Yeah, sounds good |
Hi guys!
So, in this PR, I am embedding
libwebkit2gtk-4.0
shared objects along in thedeb
package.This change will increase the
deb
file size by roughly 40 MB, but it seems to be best option right now.It still requires more testing, so I am making it a draft PR right now.
Thanks for your patience.