JSON-Schema Vulnerability #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 28, 2022 19:47
New version of jsprim includes updated json-schema version
Additional vulnerabilities found
dallendalton
previously approved these changes
Feb 1, 2022
sethobey
previously approved these changes
Feb 4, 2022
Vulnerability fixed in 7.32.0, but could not update to 8.8.0 due to ESLint errors that come up in ESLint versions later than 7.32.0
jordan-k-johnson
dismissed stale reviews from sethobey and dallendalton
via
c9c1623
|
Changed ESLint to version 7.32.0 as it was including errors for TypeScript files due to reserved keywords that are not being returned in versions prior to 8.0.0 |
sethobey
approved these changes
Feb 8, 2022
dallendalton
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue has been resolved with transitive dependency vulnerability for json-schema version <0.4.0 (prototype pollution vulnerability). Jsprim 1.4.2 has updated json-schema dependency to resolve this, version for jsprim is now being overridden to resolve issue with vulnerability. Also updated Mocha and ESLint to resolve additional vulnerabilities.