"Do not retry" from #31 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit a job could fail in one of two ways: it could fail with an Unrecoverable error, in which case it'd be ack'd and removed from the queue; or it could fail with another error and be retried with exponential backoff. There are some situations where neither is desirable; for example, you might want to delay processing a job by manually re-Enqueuing it without exponential backoff. This commit introduces a new error, ErrDoNotRetry, and makes ErrUnrecoverable wrap it. Rather than testing for equality to ErrUnrecoverable when determining if we should retry, we check if the error Is (or wraps) ErrDoNotRetry. This allows the handler (or more likely handler middleware) to more precisely control the processing of a job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nyergler
closes #17