Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWEAK: use errors.Is instead of direct comparison #51

Merged
merged 1 commit into from
Jan 19, 2021
Merged

TWEAK: use errors.Is instead of direct comparison #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ func (w *Worker) start(h handler) {
}
return nil
}()
if err != nil && err != ErrEmptyQueue && !errors.Is(err, ErrDoNotRetry) {
if err != nil && !errors.Is(err, ErrEmptyQueue) && !errors.Is(err, ErrDoNotRetry) {
errFunc(err)
}
}
Expand Down Expand Up @@ -346,7 +346,7 @@ func idleWait(d time.Duration, stop <-chan struct{}) DequeueMiddleware {
return func(opt *DequeueOptions) (*Job, error) {
job, err := f(opt)
if err != nil {
if err == ErrEmptyQueue {
if errors.Is(err, ErrEmptyQueue) {
select {
case <-time.After(d):
case <-stop:
Expand Down Expand Up @@ -375,7 +375,7 @@ func retry(queue Queue) HandleMiddleware {
return func(job *Job, opt *DequeueOptions) error {
err := f(job, opt)
if err != nil {
if err == ErrUnrecoverable {
if errors.Is(err, ErrUnrecoverable) {
return nil // ack
}
if errors.Is(err, ErrDoNotRetry) {
Expand Down