fix(multipart file uploader): using shared http client #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this resolves an issue where the HTTP client was shared and the one client was making all the requests concurrently. The built-in http client does not support this and resulted in interlaced writes, but it did sometimes succeed. The specs succeed as they never blocked the reactor and hence never actually executed in parallel. I've also added configuration to limit the number of parallel uploads as previously it was uploading the complete file at once which could exhaust memory.
|
all good now, just squash commits on merge :) |
|
Thank you for fixing this! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this resolves an issue where the HTTP client was shared and the one client was making all the requests concurrently.
The built-in http client does not support this and resulted in interlaced writes, but it did sometimes succeed. The specs succeed as they never blocked the reactor and hence never actually executed in parallel.
I've also added configuration to limit the number of parallel uploads as previously it was uploading the complete file at once which could exhaust memory.