Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis-CI to Github Workflows #98

Merged
merged 2 commits into from
May 23, 2021

Conversation

OldhamMade
Copy link
Contributor

@OldhamMade OldhamMade commented May 19, 2021

Changes

  • remove Travis-CI config file
  • add dependency for automated code checks
  • add Github Workflow to run automated code checks against recent versions of Crystal (>= 0.36.1)
  • add Github Workflow to run tests against recent versions of Crystal (>= 0.36.1)
  • change minimum Crystal version requirement to match that of dependencies
  • change patch version to reflect min Crystal version change

@@ -0,0 +1,2 @@
Excluded:
- ./lib

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary since the /lib/ folder is in the .gitignore anyways?

I've never had issues with Ameba raising errors for installed shard dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to specifically add this so that ameba didn't report errors for taylorfinnell/awscr-signer.

@taylorfinnell
Copy link
Owner

Thank you! If you're up for it let's add the matrix of versions, if not let me know and I will merge as is

@OldhamMade
Copy link
Contributor Author

Thank you! If you're up for it let's add the matrix of versions, if not let me know and I will merge as is

I'll add the matrix now; I wanted to raise the PR with just enough to be able to switch over from Travis and to start a discussion.

@OldhamMade OldhamMade force-pushed the master branch 5 times, most recently from cda9236 to 0e3d24f Compare May 20, 2021 09:05
@OldhamMade
Copy link
Contributor Author

Matrix added. Also had to change the min crystal version due to min version in the deps; bumped the version to reflect this change.

Checks are passing, but tests themselves are still failing with an Unhandled exception: File not open for writing error for an Awscr::S3::FileUploader:when the file is larger than 5MB test.

All tests are passing locally for me on macOS 11.2 with Crystal 1.0.0

@taylorfinnell
Copy link
Owner

How do I see the Action runs? Is that same test failing on travis? If so, I can just merge this and sort that out later

@stephendolan
Copy link

@taylorfinnell, unfortunately as far as I'm aware, this will need to be merged before you can actually see the new workflows running.

@taylorfinnell taylorfinnell merged commit b7f7c9f into taylorfinnell:master May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants