-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from Travis-CI to Github Workflows #98
Conversation
@@ -0,0 +1,2 @@ | |||
Excluded: | |||
- ./lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary since the /lib/
folder is in the .gitignore
anyways?
I've never had issues with Ameba raising errors for installed shard dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to specifically add this so that ameba didn't report errors for taylorfinnell/awscr-signer
.
Thank you! If you're up for it let's add the matrix of versions, if not let me know and I will merge as is |
I'll add the matrix now; I wanted to raise the PR with just enough to be able to switch over from Travis and to start a discussion. |
cda9236
to
0e3d24f
Compare
Matrix added. Also had to change the min crystal version due to min version in the deps; bumped the version to reflect this change. Checks are passing, but tests themselves are still failing with an All tests are passing locally for me on macOS 11.2 with Crystal 1.0.0 |
How do I see the Action runs? Is that same test failing on travis? If so, I can just merge this and sort that out later |
@taylorfinnell, unfortunately as far as I'm aware, this will need to be merged before you can actually see the new workflows running. |
Changes