Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#28 Remove config4k dependency #29

Merged
merged 1 commit into from
Feb 28, 2020
Merged

#28 Remove config4k dependency #29

merged 1 commit into from
Feb 28, 2020

Conversation

ihostage
Copy link
Member

@ihostage ihostage commented Feb 28, 2020 •
edited
Loading

Fixes #28

@codecov-io
Copy link

codecov-io commented Feb 28, 2020 •
edited
Loading

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage     78.83%   78.83%           
  Complexity      126      126           
=========================================
  Files            14       14           
  Lines           326      326           
  Branches         67       67           
=========================================
  Hits            257      257           
  Misses           20       20           
  Partials         49       49
Impacted Files Coverage Δ Complexity Δ
...yr/lagom/javadsl/openapi/AbstractOpenAPIService.kt 91.42% <66.66%> (ø) 9 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1db5ebd...8fa6aea. Read the comment docs.

@ihostage ihostage merged commit 734cbc5 into master Feb 28, 2020
@ihostage ihostage deleted the issue/28 branch February 28, 2020 22:54
@ihostage ihostage added the dependency Bumps the version of the dependency. label Mar 4, 2020
@ihostage ihostage changed the title #28 Remove dependency from config4k #28 Remove config4k dependency Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependency Bumps the version of the dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency from config4k
2 participants
@ihostage @codecov-io