Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAPI routes mixin refactorings #44

Merged
merged 1 commit into from
Oct 14, 2020
Merged

OpenAPI routes mixin refactorings #44

merged 1 commit into from
Oct 14, 2020

Conversation

gnuzzz
Copy link
Contributor

@gnuzzz gnuzzz commented Oct 13, 2020 •
edited by ihostage
Loading

Related with lagom/lagom#3058

@ihostage ihostage added the enhancement New feature or request label Oct 14, 2020
ihostage
ihostage approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@ihostage ihostage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ihostage ihostage added this to the 1.2.2 milestone Oct 14, 2020
@codecov-io
Copy link

codecov-io commented Oct 14, 2020 •
edited
Loading

Codecov Report

Merging #44 into master will decrease coverage by 0.57%.
The diff coverage is 62.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #44      +/-   ##
============================================
- Coverage     77.37%   76.79%   -0.58%     
+ Complexity      137      136       -1     
============================================
  Files            17       17              
  Lines           358      362       +4     
  Branches         71       71              
============================================
+ Hits            277      278       +1     
- Misses           30       32       +2     
- Partials         51       52       +1
Impacted Files Coverage Δ Complexity Δ
...taymyr/lagom/scaladsl/openapi/OpenAPIService.scala 66.66% <50.00%> (-33.34%) 2.00 <1.00> (ø)
...org/taymyr/lagom/javadsl/openapi/OpenAPIService.kt 75.00% <75.00%> (-25.00%) 0.00 <0.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3473585...4bf0efc. Read the comment docs.

@ihostage ihostage merged commit 87918cd into taymyr:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihostage ihostage ihostage approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@gnuzzz @codecov-io @ihostage