Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement automated release management improvements #9

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

scott45
Copy link
Contributor

@scott45 scott45 commented Nov 6, 2024

SPDX-License-Identifier: Apache-2.0

What did we change?

Implement cicd working group changes

Why are we doing this?

cicd recon

How was it tested?

  • Locally
  • Development Environment
  • Not needed, changes very basic
  • Husky successfully run
  • Unit tests passing and Documentation done

@scott45 scott45 self-assigned this Nov 6, 2024
@github-actions github-actions bot added the enhancement New feature or request label Nov 6, 2024
.github/workflows/npm-publish-dev.yml Dismissed Show dismissed Hide dismissed
jobs:
build-and-publish:
runs-on: ubuntu-latest
permissions:

Check notice

Code scanning / Checkov (reported by Codacy)

Ensure top-level permissions are not set to write-all Note

Ensure top-level permissions are not set to write-all
.github/workflows/release.yml Fixed Show fixed Hide fixed
@scott45 scott45 marked this pull request as draft November 6, 2024 06:59
.github/workflows/release.yml Dismissed Show dismissed Hide dismissed
Sandy-at-Tazama
Sandy-at-Tazama previously approved these changes Nov 6, 2024
Copy link
Contributor

@rtkay123 rtkay123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments in the code

.github/workflows/npm-publish-main.yml Outdated Show resolved Hide resolved
.github/workflows/npm-publish-dev.yml Outdated Show resolved Hide resolved
Sandy-at-Tazama
Sandy-at-Tazama previously approved these changes Nov 8, 2024
@scott45 scott45 marked this pull request as ready for review November 13, 2024 17:22
@scott45 scott45 merged commit de0f2b1 into dev Nov 13, 2024
16 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants