edit original post #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,87 +31,77 @@ func main() { | |||
| } | |||
| ``` | |||
|
|
|||
| Looks about as innocuous as nonsensical, right? If we run it naively, nothing happens: | |||
| Looks about as innocuous as nonsensical, right? If we run it naively, nothing | |||
There was a problem hiding this comment.
s/as nonsensical/as it is nonsensical/g
There was a problem hiding this comment.
done.
On Tue, Dec 15, 2015 at 11:15 AM Peter Mattis notifications@github.com
wrote:
In cgo_libc_static/README.md
#2 (comment):@@ -22,87 +31,77 @@ func main() {
}-Looks about as innocuous as nonsensical, right? If we run it naively, nothing happens: +Looks about as innocuous as nonsensical, right? If we run it naively, nothings/as nonsensical/as it is nonsensical/g
—
Reply to this email directly or view it on GitHub
https://github.com/tschottdorf/goplay/pull/2/files#r47658032.
|
LGTM |
| @@ -111,26 +110,27 @@ fatal error: unexpected signal during runtime execution | |||
| goroutine 3890 [syscall, locked to thread]: | |||
| runtime.cgocall(0x44c7f0, 0xc82036a8d8, 0xc800000000) | |||
| /usr/local/go/src/runtime/cgocall.go:120 +0x11b fp=0xc82036a888 sp=0xc82036a858 | |||
| os/user._Cfunc_mygetpwuid_r(0x0, 0xc8203a8390, 0x7f3c5c000a10, 0x400, 0xc8200e4058, 0x7f3c00000000) | |||
There was a problem hiding this comment.
I wouldn't remove this, this is the symbol you'd actually find in the symbol table
There was a problem hiding this comment.
hmm, good point. Reinstating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully making it better.