Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peakachu crashes with pandas>0.20.3 #8

Closed
dmaticzka opened this issue Jan 31, 2018 · 3 comments
Closed

peakachu crashes with pandas>0.20.3 #8

dmaticzka opened this issue Jan 31, 2018 · 3 comments

Comments

@dmaticzka
Copy link
Collaborator

peakachu throws

TypeError: reduction operation 'argmax' not allowed for this dtype

looks connected to pandas-dev/pandas#18021, also seems to be a workaround there
@tbischler
Copy link
Owner

I committed a fix to master, please test.

@mbargull mbargull mentioned this issue Jan 31, 2018
Merged
5 tasks
@dmaticzka
Copy link
Collaborator Author

travis should run again. if the tests work we should be okay

@dmaticzka
Copy link
Collaborator Author

kk, patch works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmaticzka @tbischler