WIP fix peakachu dependencies #7434
Conversation
dmaticzka
commented
Jan 30, 2018
dmaticzka
commented
- I have read the guidelines for bioconda recipes.
- This PR adds a new recipe.
- AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
- This PR updates an existing recipe.
- This PR does something else (explain below).
|
CCI was someone stuck, lets try to re-trigger the test here. |
There was a problem hiding this comment.
@dmaticzka, you need to rebase on (or merge) master into your branch.
recipes/peakachu/meta.yaml
Outdated
| @@ -21,7 +21,7 @@ requirements: | |||
| - setuptools | |||
| - "biopython >=1.69" | |||
| - "matplotlib >=2.0.2" | |||
| - "pandas >=0.20.2" | |||
| - "pandas >=0.20.2 <=0.20.3" | |||
There was a problem hiding this comment.
Should be pandas >=0.20.2,<=0.20.3, note the comma.
recipes/peakachu/meta.yaml
Outdated
| @@ -32,7 +32,7 @@ requirements: | |||
| - python | |||
| - "biopython >=1.69" | |||
| - "matplotlib >=2.0.2" | |||
| - "pandas >=0.20.2" | |||
| - "pandas >=0.20.2 <=0.20.3" | |||
|
@dmaticzka, can you explain why that version restriction on |
|
@mbargull it's a bug related to pandas-dev/pandas#18021. pending resolution in either pandas or peakachu, peakachu will only work with either pandas version 0.20.2 or 0.20.3 |
|
@dmaticzka I assume this one it not WIP anymore? |
|
@bgruening, there is an open issue and a commit that's meant to fix that bug. If @dmaticzka can confirm this work, we could rather add a patch. |
|
in principle this should fix it, didn't stay up late for the circleci results to finally trickle in :) this, the patch, or a new version for the patch would all work for me. i have to take care of a paper submission, so i can't check on that patch until end of next week. |
|
Ah, sorry, forgot to hit that "Approve" button. Thanks @dmaticzka! |
