Migrate to Node 12 #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briannielson
commented
May 11, 2020
| @@ -1,8 +1,11 @@ | |||
| { | |||
| 'targets': [ | |||
| { | |||
| 'include_dirs':[ | |||
| '<(module_root_dir)/node_modules/nan', | |||
There was a problem hiding this comment.
I would like to change binding.gyp to pull from the server node_modules directory if at all possible, but I don't think I can.
briannielson
commented
May 11, 2020
| "colors": "~0.6.0-1", | ||
| "bindings": "*" | ||
| "nan": "^2.14.1" |
There was a problem hiding this comment.
Bringing in nan to help with some of the string and integer types.
briannielson
commented
May 11, 2020
| } | ||
|
|
||
| void init(v8::Handle<v8::Object> target) { | ||
| void init(v8::Local<v8::Object> target) { |
There was a problem hiding this comment.
v8::Handle has been deprecated for a while, but it was finally removed in v8 used for node 12.
briannielson
commented
May 11, 2020
| v8::Isolate* isolate = args.GetIsolate(); | ||
| args[0]->ToString(Nan::GetCurrentContext()).FromMaybe(v8::Local<v8::String>())->WriteUtf8(isolate, (char*) &title); | ||
| int32_t facility = args[1]->ToInt32(Nan::GetCurrentContext()).ToLocalChecked()->Value(); | ||
| int32_t log_upto = args[2]->ToInt32(Nan::GetCurrentContext()).ToLocalChecked()->Value(); |
There was a problem hiding this comment.
Helpful notes on migration from another repo bcoin-org/bcrypto#7
|
Whoops, looks like I was on the wrong repo. Feel free to use any of this if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress, but wanted to highlight some changes with this package.