Option to spawn a process with CREATE_NO_WINDOW on windows #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/tboox/tbox/blob/master/src/tbox/platform/process.h#L41 |
https://github.com/tboox/tbox/blob/master/src/tbox/platform/process.h#L41 |
waruqi
reviewed
Oct 20, 2023
da-liii
changed the title
waruqi
reviewed
Oct 23, 2023
src/tbox/platform/process.h
Outdated
| @@ -43,6 +43,7 @@ typedef enum __tb_process_flag_e | |||
| TB_PROCESS_FLAG_NONE = 0 | |||
| , TB_PROCESS_FLAG_SUSPEND = 1 //!< suspend process | |||
| , TB_PROCESS_FLAG_DETACH = 2 //!< all subprocesses will be exited when the parent process is exited (ctrl+c or onexit) if this flag is not setted | |||
| , TB_PROCESS_FLAG_NO_WINDOW = 4 //!< avoid to launch the console | |||
There was a problem hiding this comment.
注释可以再写详细点，如果仅仅只对 windows 有效，最好提下，如果其他平台也支持，那就一并处理下
There was a problem hiding this comment.
这个仅仅对windows有效，因为别的平台不需要处理这个问题
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #244
In most cases, the spawned process is console app without UI. That's why I set the CREATE_NO_WINDOW flag directly.