Version info : accept zero-length string values

tc-hib · Mar 18, 2024 · bae858a · bae858a
1 parent 5922870
commit bae858a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/version/binary.go b/version/binary.go
@@ -376,7 +376,10 @@ func readString(data []byte, pos *int) (string, error) {
 func readStringWithLength(data []byte, pos *int, length int) (string, error) {
 	data = data[*pos:]
 
-	if length == 0 || length > len(data)/2 {
+	if length == 0 {
+		return "", nil
+	}
+	if length < 0 || length > len(data)/2 {
 		return "", errors.New(errInvalidStringLength)
 	}
 

diff --git a/version/testdata/TestFromBytes_ErrStringLength.golden b/version/testdata/TestFromBytes_ErrStringLength.golden