Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add %JSONParse% for Fetch et al #1013

Merged
merged 2 commits into from
Sep 28, 2017
Merged

Add %JSONParse% for Fetch et al #1013

merged 2 commits into from
Sep 28, 2017

Conversation

annevk
Copy link
Member

@annevk annevk commented Sep 28, 2017

Fixes #1012.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@annevk
Copy link
Member Author

annevk commented Sep 28, 2017

Not mentioning it in prose was modeled after %Int32ArrayPrototype%, though I notice that for %ObjProto_valueOf% we do mention it in prose:

This function is the %ObjProto_valueOf% intrinsic object.

The latter probably also has an ID therefore. Was not mentioning the former an oversight?

(I also noticed some other inconsistencies for which I'll submit a separate PR.)

@ljharb
Copy link
Member

ljharb commented Sep 28, 2017

I was wondering about that; I think it's better to have a dual link, and to mention it in both places (for all intrinsics).

@annevk
Copy link
Member Author

annevk commented Sep 28, 2017

Added here for JSON.parse. Per https://tc39.github.io/ecma262/#sec-well-known-intrinsic-objects there's quite a few not linked. I'm happy to file a follow-up issue for those, but I'm not going to work on a PR for now.

@domenic
Copy link
Member

domenic commented Sep 28, 2017

See #1012 (comment) for a potential slightly cleaner alternative. But either will work. I'll try to ask @bterlson in person today.

@bterlson
Copy link
Member

I selfishly prefer this approach as it's cleaner in 262.

@bterlson bterlson merged commit 746fe62 into tc39:master Sep 28, 2017
@annevk annevk deleted the annevk/jsonparse branch September 28, 2017 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants