Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Symbol.prototype.description getter #1346

Merged
merged 1 commit into from
Feb 20, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions spec.html
Original file line number Diff line number Diff line change
Expand Up @@ -25027,6 +25027,16 @@ <h1>Runtime Semantics: SymbolDescriptiveString ( _sym_ )</h1>
</emu-clause>
</emu-clause>

<emu-clause id="sec-symbol.prototype.description">
<h1>get Symbol.prototype.description</h1>
<p>`Symbol.prototype.description` is an accessor property whose set accessor function is *undefined*. Its get accessor function performs the following steps:</p>
<emu-alg>
1. Let _s_ be the *this* value.
1. Let _sym_ be ? thisSymbolValue(_s_).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also do

Let _sym_ be ? thisSymbolValue(*this* value).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reigning convention seems to be to have it in a separate variable; i don’t have a strong opinion either way as long as we’re consistent.

1. Return _sym_.[[Description]].
</emu-alg>
</emu-clause>

<emu-clause id="sec-symbol.prototype.valueof">
<h1>Symbol.prototype.valueOf ( )</h1>
<p>The following steps are taken:</p>
Expand Down