Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: add String.prototype.matchAll/Symbol.matchAll #1480

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Normative: add String.prototype.matchAll/Symbol.matchAll #1480

merged 1 commit into from
Apr 10, 2019

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Mar 15, 2019

@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. has test262 tests proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. labels Mar 15, 2019
@ljharb ljharb mentioned this pull request Mar 15, 2019
Closed
28 tasks
@mathiasbynens
Copy link
Member

cc @schuay @hashseed @peterwmwong

@targos targos mentioned this pull request Mar 15, 2019
Closed
14 tasks
@ljharb ljharb added has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. and removed pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Mar 26, 2019
@ljharb ljharb self-assigned this Mar 26, 2019
@ljharb ljharb merged commit 71927e1 into tc39:master Apr 10, 2019
@ljharb ljharb deleted the matchall branch April 10, 2019 23:06
@ljharb ljharb mentioned this pull request Apr 13, 2019
Merged
@saschanaz saschanaz mentioned this pull request Apr 15, 2019
Closed
5 tasks
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Apr 29, 2019
@jmdyck
Editorial: Various tweaks re String.prototype.matchAll
436c164 
These edits all relate to commit 71927e1 from PR tc39#1480.

- Markup: repair a malformed <emu-xref> tag

- Editorial: Append "then" to "If" steps

- Markup: change hyphens to dots in clause-id for String.prototype.matchAll

- Editorial: Change RIGHT SINGLE QUOTATION MARK to APOSTROPHE
  (U+2019 to U+0027)

- Markup: Remove underscores from "_CreateRegExpStringIterator_"
  ... because it's not a variable.

- Editorial: dissolve 2 <emu-xref> elements
  ... that should be handled by ecmarkup's auto-linking.

- Markup: Use conventional format for clause-ids
  (for clauses relating to RegExp String Iterator Object + Instances)

- Editorial: Define %RegExpStringIteratorPrototype% like other intrinsics

- Editorial: Insert space before square-bracket
  ... in "%RegExpStringIteratorPrototype% [ @@toStringTag ]"

- Editorial: Hoist "Properties of RegExp String Iterator Instances" clause
  Move it 'up' one level
  (pop it out of "The %RegExpStringIteratorPrototype% Object" clause),
  because it's not defining a property of %RegExpStringIteratorPrototype%.

- Markup: Tweak "Internal Slots of RegExp String Iterator Instances" table.
  Change <figure>/<figurecaption>/<span> to <emu-table>.
  Change the id from "table-1" to something more mnemonic.
  Delete spurious "<tr>" tag.
  Refer to it with an <emu-xref> rather than an <a> element.

(Originally, these were 11 separate commits,
but @ljharb requested that I collapse them.)
ljharb pushed a commit to jmdyck/ecma262 that referenced this pull request May 2, 2019
@jmdyck @ljharb
Editorial: Various tweaks re String.prototype.matchAll (tc39#1509)
046117a 
These edits all relate to commit 71927e1 from PR tc39#1480.

- Markup: repair a malformed <emu-xref> tag

- Editorial: Append "then" to "If" steps

- Markup: change hyphens to dots in clause-id for String.prototype.matchAll

- Editorial: Change RIGHT SINGLE QUOTATION MARK to APOSTROPHE
  (U+2019 to U+0027)

- Markup: Remove underscores from "_CreateRegExpStringIterator_"
  ... because it's not a variable.

- Editorial: dissolve 2 <emu-xref> elements
  ... that should be handled by ecmarkup's auto-linking.

- Markup: Use conventional format for clause-ids
  (for clauses relating to RegExp String Iterator Object + Instances)

- Editorial: Define %RegExpStringIteratorPrototype% like other intrinsics

- Editorial: Insert space before square-bracket
  ... in "%RegExpStringIteratorPrototype% [ @@toStringTag ]"

- Editorial: Hoist "Properties of RegExp String Iterator Instances" clause
  Move it 'up' one level
  (pop it out of "The %RegExpStringIteratorPrototype% Object" clause),
  because it's not defining a property of %RegExpStringIteratorPrototype%.

- Markup: Tweak "Internal Slots of RegExp String Iterator Instances" table.
  Change <figure>/<figurecaption>/<span> to <emu-table>.
  Change the id from "table-1" to something more mnemonic.
  Delete spurious "<tr>" tag.
  Refer to it with an <emu-xref> rather than an <a> element.

(Originally, these were 11 separate commits,
but @ljharb requested that I collapse them.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@littledan littledan littledan approved these changes

@zenparsing zenparsing zenparsing approved these changes

Assignees

@ljharb ljharb

Labels
has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ljharb @mathiasbynens @littledan @zenparsing