Normative: Fixed bug in Number::unsignedRightShift #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Apr 20, 2020
michaelficarra
added
editor call
ljharb
approved these changes
Apr 22, 2020
ljharb
force-pushed
the
bug-in-number-unsignedrightshift
branch
from
35030f4
to
16387ec
Compare
ljharb
added
normative change
|
Sorry for late comment here. I confirm this was a bug introduced with BigInt PR. Thanks for fixing it. |
ljharb
pushed a commit
that referenced
this pull request
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version ES2019, The Unsigned Right Shift Operator(
>>>) utilizeToUint32for both left and right expressions. However, the current version applyToUint32for only the right number value but useToInt32for the left number value inNumber::unsignedRightShift. I think it breaks the backward compatibility thus I revised the semantics ofNumber::unsignedRightShiftto useToUint32for both left and right number value.