Fixed bugs in return type of CatchClauseEvaluation algorithm #2920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found the return type bug in the syntax-directed operation: 14.15.2 Runtime semantics: CatchClauseEvaluation via ESMeta type analyzer.
Currently, the type of
CatchClauseEvaluation
is defined as follows:However, I think its return type should contain
a normal completion containing ~empty~
.In step 7 for
Catch : `catch` `(` CatchParameter `)` Block
case, the variableB
stores the result ofEvaluation of |Block|
. According to 14.2.2 Runtime Semantics: Evaluation, the variableB
might be a normal completion containing~empty~
. Then, step 9 returns the value stored in the variableB
.Similarly, in step 1 for
Catch : `catch` Block
case, it directly returns the result ofEvaluation of |Block|
.Therefore, I suggest extending its return type as follows: