Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Allow implementations to pad timeouts in SuspendAgent #2973

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Normative: Allow implementations to pad timeouts in SuspendAgent #2973

merged 1 commit into from
Jan 5, 2023

Conversation

syg
Copy link
Contributor

@syg syg commented Dec 15, 2022

Closes #2914.

@syg syg added normative change Affects behavior required to correctly evaluate some ECMAScript source text has consensus This has committee consensus. labels Dec 15, 2022
@syg syg requested a review from a team December 15, 2022 00:17
michaelficarra
michaelficarra reviewed Dec 15, 2022
View reviewed changes
spec.html Outdated Show resolved Hide resolved
michaelficarra
michaelficarra approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

@gibson042 gibson042 mentioned this pull request Dec 16, 2022
Closed
gibson042
gibson042 reviewed Dec 16, 2022
View reviewed changes
Copy link
Contributor

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I closed #2965 in favor of the fix happening here.

spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
@syg syg added the editor call to be discussed in the next editor call label Jan 4, 2023
@syg syg force-pushed the allow-atomics-wait-coarsen branch from b8a60f6 to c095180 Compare January 5, 2023 01:25
@syg
Copy link
Contributor Author

syg commented Jan 5, 2023

I closed #2965 in favor of the fix happening here.

Sorry! I didn't realize you already had a PR open before I uploaded this.

@bakkot bakkot added ready to merge Editors believe this PR needs no further reviews, and is ready to land. and removed editor call to be discussed in the next editor call labels Jan 5, 2023
@ljharb ljharb merged commit 89ef660 into tc39:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibson042 gibson042 gibson042 left review comments

@bakkot bakkot bakkot approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

Assignees
No one assigned
Labels
has consensus This has committee consensus. normative change Affects behavior required to correctly evaluate some ECMAScript source text ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Atomics.wait and SuspendAgent disagree about the domain of valid timeouts
5 participants
@syg @michaelficarra @gibson042 @bakkot @ljharb