Editorial: Quick fixes re PR #2418 #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
approved these changes
Jun 16, 2023
|
Not sure why ecmarkup is complaining; I'll look into it. |
|
ecmarkup is failing because it says that the closure in CharacterSetMatcher captures |
michaelficarra
approved these changes
Jun 20, 2023
This was referenced Jul 3, 2023
ljharb
pushed a commit
that referenced
this pull request
Jul 4, 2023
bakkot
added
the
ready to merge
|
Note for history: this PR originally had 4 commits, the first of which got merged to main on its own, along with PR #3113. (I've just squashed the remaining 3 commits down to one.) |
syg
approved these changes
Jul 7, 2023
- In CompileAtom, take the wording-changes under `Atom :: CharacterClass` that were prompted by tc39#2418 (comment) and copy them to `AtomEscape :: CharacterClassEscape`. - In various operations, change more occurrences of 'element' to 'CharSetElement'. - In CompileAtom, change 2 occurrences of "which" to "that" because the usage is restrictive.
zhangenming
pushed a commit
to zhangenming/ecma262
that referenced
this pull request
Dec 22, 2023
zhangenming
pushed a commit
to zhangenming/ecma262
that referenced
this pull request
Dec 22, 2023
- In CompileAtom, take the wording-changes under `Atom :: CharacterClass` that were prompted by tc39#2418 (comment) and copy them to `AtomEscape :: CharacterClassEscape`. - In various operations, change more occurrences of 'element' to 'CharSetElement'. - In CompileAtom, change 2 occurrences of "which" to "that" because the usage is restrictive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.