Editorial: Remove unnecessary If in SystemTimeZoneIdentifier
#3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justingrant
added a commit
to tc39/proposal-canonical-tz
that referenced
this pull request
Jun 21, 2023
This commit rebases one line of SystemTimeZoneIdentifier on tc39/ecma262#3104.
syg
approved these changes
Jun 21, 2023
michaelficarra
approved these changes
Jun 21, 2023
michaelficarra
added
the
ready to merge
Removes an unnecessary line in SystemTimeZoneIdentifier. Originally this AO contained an assert that applied to named time zones but not offset time zones. Based on editors' feedback in tc39#3035, this assertion was replaced with different text, making the remaining If statement unnecessary. But I didn't notice this until after tc39#3035 was merged. This commit removes the now-unnecessary If statement.
ljharb
force-pushed
the
system-identifier-redundant-line
branch
from
a84638e
to
f609768
Compare
zhangenming
pushed a commit
to zhangenming/ecma262
that referenced
this pull request
Dec 22, 2023
Removes an unnecessary line in SystemTimeZoneIdentifier. Originally this AO contained an assert that applied to named time zones but not offset time zones. Based on editors' feedback in tc39#3035, this assertion was replaced with different text, making the remaining If statement unnecessary. But I didn't notice this until after tc39#3035 was merged. This commit removes the now-unnecessary If statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the SystemTimeZoneIdentifier AO contained an assert that applied to named time zones but not offset time zones. Based on editors' feedback in #3035, this assertion was removed and replaced with different text, making the remaining If statement unnecessary. But I didn't notice this until after #3035 was merged.
This commit removes the now-unnecessary
Ifstatement.