Editorial: OrdinaryCreateFromConstructor has wrong parameter type #3287
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tutizaraz
changed the title
|
@tutizaraz can you please confirm that you did not use a LLM (AI) for any part of this PR? |
|
@ljharb for english grammar only because it is not my native language |
ljharb
reviewed
Feb 26, 2024
ljharb
changed the title
linusg
suggested changes
Mar 7, 2024
spec.html
Outdated
| _intrinsicDefaultProto_: a String, | ||
| optional _internalSlotsList_: a List of names of internal slots, | ||
| ): either a normal completion containing an Object or a throw completion | ||
| </h1> | ||
| <dl class="header"> | ||
| <dt>description</dt> | ||
| <dd>It creates an ordinary object whose [[Prototype]] value is retrieved from a constructor's *"prototype"* property, if it exists. Otherwise the intrinsic named by _intrinsicDefaultProto_ is used for [[Prototype]]. _internalSlotsList_ contains the names of additional internal slots that must be defined as part of the object. If _internalSlotsList_ is not provided, a new empty List is used.</dd> | ||
| <dd>It creates an ordinary object whose [[Prototype]] value is retrieved from a function object's *"prototype"* property, if it exists. This object is referred to by _constructor_, which can be any function object. If the *"prototype"* property does not exist or _constructor_ is not a traditional constructor, the intrinsic named by _intrinsicDefaultProto_ is used for [[Prototype]]. _internalSlotsList_ contains the names of additional internal slots that must be defined as part of the object. If _internalSlotsList_ is not provided, a new empty List is used.</dd> |
There was a problem hiding this comment.
"traditional constructor" is not a defined term - either it's a constructor, or it isn't. This also isn't relevant here, the non-constructor cases do have a prototype property so intrinsicDefaultProto is not necessarily used for those.
There was a problem hiding this comment.
then do we need to revert the changes back to what it was?
There was a problem hiding this comment.
Yes, I think the original description is fine.
michaelficarra
approved these changes
Oct 2, 2024
syg
approved these changes
Oct 2, 2024
michaelficarra
added
the
ready to merge
michaelficarra
force-pushed
the
normative-update-OrdinaryCreateFromConstructor-first-arg-to-function-object
branch
from
8725a65
to
097a439
Compare
bakkot
approved these changes
Oct 2, 2024
ljharb
force-pushed
the
normative-update-OrdinaryCreateFromConstructor-first-arg-to-function-object
branch
from
84b70ba
to
aada408
Compare
|
@tutizaraz would you please register as a contributor ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3168